refactor: replace custom logger with tracing and standard subscriber#130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces structured logging to the project by replacing ad-hoc and print-based logging with the
tracingcrate and its subscriber. It removes the custom file-basedlog_debugfunction and updates log statements throughout the codebase to use the new logging framework. This will provide more flexible, configurable, and production-ready logging.The most important changes are:
Logging infrastructure improvements:
tracingandtracing-subscriberdependencies toCargo.tomlto enable structured, leveled logging throughout the application.log_debugfunction and all direct file-based logging fromsrc/main.rs, replacing them withtracingmacros (debug!,info!,error!). Initialized the subscriber with environment-based filtering and improved log formatting.Codebase logging updates:
println!statements insrc/ui/file_explorer.rswithtracing::debug!for drop events and file upload operations, ensuring all logs are consistent and configurable. [1] [2]Application startup:
info!.